Retry to fix object spread helper compatibility #9384

saschanaz · 2019-01-22T09:01:45Z

Q	A
Fixed Issues?	Fixes #9322
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?	Yes
Documentation PR Link
Any Dependency Changes?
License	MIT

Retries #9341.

This adds helpers._objectSpread2() where only the even arguments would be considered as spreads.

nicolo-ribaudo · 2019-01-22T09:43:51Z

Can you add a comment that the old helper can be removed in the next major release?

saschanaz · 2019-01-22T09:54:08Z

No idea what's causing failure to rename.

saschanaz · 2019-01-22T09:54:50Z

Can you add a comment that the old helper can be removed in the next major release?

Inside the helper or above helpers.objectSpread line?

babel-bot · 2019-01-22T11:13:56Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10860/

saschanaz · 2019-01-22T11:14:57Z

It seems somehow the helper name can't include a trailing number?

nicolo-ribaudo · 2019-01-22T12:07:05Z

Yeah it can. It will be renamed to _objectSpread when inlined but it isn't a problem: @babel/runtime/helpers/objectSpread will still point to the old helper and @babel/runtime/helpers/objectSpread2 to the new one.

saschanaz · 2019-02-07T04:59:03Z

Can this be merged or do this have any more blockers?

saschanaz · 2019-02-18T00:42:41Z

Any news for this? @nicolo-ribaudo

saschanaz · 2019-02-22T04:56:33Z

@nicolo-ribaudo How about we just treat null/undefined always as {}? That way we can keep the compatibility with the previous behavior without adding objectSpread2.

nicolo-ribaudo · 2019-02-22T09:36:19Z

It wouldn't work, because the old helper handles all the arguments the same way.

saschanaz · 2019-02-22T10:08:00Z

The previous issue was that the old code didn’t work with the new helper because the helper assumed that the odd arguments are all objects. Modifying that behavior to also accept null/undefined should fix the specific issue.

…

________________________________ From: Nicolò Ribaudo <notifications@github.com> Sent: Friday, February 22, 2019 6:36:38 PM To: babel/babel Cc: Kagami Sascha Rosylight; Author Subject: Re: [babel/babel] Retry to fix object spread helper compatibility (#9384) It wouldn't work, because the old helper handles all the arguments the same way. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://nam05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbabel%2Fbabel%2Fpull%2F9384%23issuecomment-466335255&data=02%7C01%7C%7C9686f159844d40ee11e308d698a93f15%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636864250000910849&sdata=BhdClNGJWM%2B0itD%2BogKAw1M5v4voWPBzabl%2BWvQvY2I%3D&reserved=0>, or mute the thread<https://nam05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADPUToTEfwqohLJAG1TEVNBo8uFKeHj2ks5vP7omgaJpZM4aMNXC&data=02%7C01%7C%7C9686f159844d40ee11e308d698a93f15%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636864250000920854&sdata=RJCsefcY99I5dj9IdLlm7dTWluR5ABuFJXWC2TgMbqA%3D&reserved=0>.

danez · 2019-03-01T21:26:08Z

packages/babel-helpers/src/helpers.js

+helpers.objectSpread2 = helper("7.0.0-beta.0")`
+  import defineProperty from "defineProperty";
+
+  export default function _objectSpread(target) {


Should it be named objectSpread2? I wonder in the case someone uses babel-runtime, this might be a problem, but I don't know exactly how runtime works.

Since this is a default export, the name doesn't matter.
Anyway, we should rename it for consistency.

But where is the name in generated output coming from? Because right now it is called _objectSpread even with he new helper, which made me think it might collide in the runtime again.

I thought it might be the name of the function here.

It does generateUidIdentifier("objectSpread2"), which removes 2 before generating the id.

Would objectSpreadTwo is okay or should I fix the function to not remove 2?

It's ok as it is now for me.

You mean this can be ignored?

Anyway, we should rename it for consistency.

We should rename the helper:

export default function _objectSpread2

But is is not a problem if that 2 then gets automatically removed by generateUid.

danez

Sorry for the long wait. Can you please rebase the PR, so that it can be merged?

packages/babel-helpers/src/helpers.js

buildsize · 2019-05-25T03:06:53Z

File name	Previous Size	New Size	Change
babel-preset-env.js	2.28 MB	2.05 MB	-235.61 KB (10%)
babel-preset-env.min.js	1.31 MB	1.1 MB	-213.93 KB (16%)
babel.js	2.82 MB	2.77 MB	-46.25 KB (2%)
babel.min.js	1.56 MB	1.55 MB	-18.31 KB (1%)

…babel#9341)" (babel#9379)" This reverts commit 43b83f8. Fix objectSpread helper breaking old codes remove tests to regenerate later renamed output new name try using word add comment as requested revert inline name changes add 2 for consistency Update packages/babel-helpers/src/helpers.js Co-Authored-By: Daniel Tschinder <daniel@tschinder.de>

nicolo-ribaudo · 2019-05-25T10:57:22Z

Thanks!

mathieutu · 2019-06-01T12:59:22Z

Hi folks. Thanks for you work.

Just to be sure, do you confirm that this PR will fix the issue #8749?

Do you have any idea of its release planning?

Thanks!

cloudkite · 2019-07-05T03:17:04Z

This change breaks IE11 compatibility when using object spread syntax without using polyfills as getOwnPropertyDescriptors is not available in IE11.

nicolo-ribaudo · 2019-07-05T04:32:48Z

Could you please open a new issue? 🙏

QingLeiLi · 2019-07-05T09:24:47Z

I got the error

ModuleNotFoundError: Module not found: Error: Can't resolve '@babel/runtime/helpers/objectSpread2'

There must be something wrong in babel-plugin-proposal-object-rest-spread.

ADD：objectSpread2 was add in the @babel/runtime-corejs2 package, but the helperGenerator method will search the helper in the @babel/runtime package only, except set the corejs option to 2.

pwnreza · 2019-07-05T11:26:52Z

Same error as referenced by @edi9999
We are depending on building our RN app via pre-installed set of node_modules.
So we are pretty desperate for a fix 🙏

kimroen · 2019-07-05T11:31:55Z

I got the error

ModuleNotFoundError: Module not found: Error: Can't resolve '@babel/runtime/helpers/objectSpread2'

There must be something wrong in babel-plugin-proposal-object-rest-spread.

ADD：objectSpread2 was add in the @babel/runtime-corejs2 package, but the helperGenerator method will search the helper in the @babel/runtime package only, except set the corejs option to 2.

We're getting a similar error after upgrading from 7.4.3 to 7.5.0. The error we're getting is this:

"Unknown helper objectSpread2".

QingLeiLi · 2019-07-05T11:37:21Z

I got the error

ModuleNotFoundError: Module not found: Error: Can't resolve '@babel/runtime/helpers/objectSpread2'

There must be something wrong in babel-plugin-proposal-object-rest-spread.
ADD：objectSpread2 was add in the @babel/runtime-corejs2 package, but the helperGenerator method will search the helper in the @babel/runtime package only, except set the corejs option to 2.

We're getting a similar error after upgrading from 7.4.3 to 7.5.0. The error we're getting is this:

"Unknown helper objectSpread2".

Yeah, add @babel/plugin-transform-runtime option
{ corejs: 2, }
make it works again.

Udbhav12 · 2019-07-05T11:58:43Z

@QingLeiLi Can you please share your entire package.json file ?

QingLeiLi · 2019-07-08T02:25:40Z

@QingLeiLi Can you please share your entire package.json file ?

package.json ? Do you mean babel config?

// babel.config.js
module.exports = {
        presets: [
            [
                '@babel/preset-env',
                {
                    modules: 'false',
                    targets: {
                        ios: '9',
                        android: '4.4'
                    },
                    useBuiltIns: 'usage'
                }
            ],
            ['@babel/preset-react'],
            ['@babel/preset-typescript']
        ],
        plugins: [
            ['@babel/plugin-transform-runtime', {
            	// point
                "corejs": 2,
            }],
            '@babel/plugin-proposal-class-properties',
            [
                "@babel/plugin-proposal-decorators",
                {
                    "decoratorsBeforeExport": false
                }
            ]
        ],
};

pwnreza · 2019-07-08T14:54:42Z

Same error as referenced by @edi9999
We are depending on building our RN app via pre-installed set of node_modules.
So we are pretty desperate for a fix 🙏

See here

kimroen · 2019-07-08T14:57:57Z

Just wanted to mention that the issue I was describing above was fixed by this PR: #10170

nicolo-ribaudo approved these changes Jan 23, 2019

View reviewed changes

nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories PR: Needs Review A pull request awaiting more approvals labels Feb 22, 2019

danez reviewed Mar 1, 2019

View reviewed changes

danez approved these changes May 25, 2019

View reviewed changes

packages/babel-helpers/src/helpers.js Outdated Show resolved Hide resolved

danez added this to the v7.5.0 milestone May 25, 2019

saschanaz force-pushed the spread-fix branch from 56aafa8 to 2d3ce65 Compare May 25, 2019 04:05

nicolo-ribaudo added Spec: Object Rest/Spread and removed PR: Needs Review A pull request awaiting more approvals labels May 25, 2019

nicolo-ribaudo merged commit a596da2 into babel:master May 25, 2019

nicolo-ribaudo removed this from the v7.5.0 milestone May 25, 2019

mathieutu mentioned this pull request Jun 1, 2019

Spread operator mismatches native behavior when getter is used #8749

Closed

HillLiu mentioned this pull request Jul 5, 2019

follow-up objectSpread2 react-atomic/reshow#12

Closed

edi9999 mentioned this pull request Jul 5, 2019

undefined is not a function(evaluation 'object.getOwnPropertyDescriptors(arguments[i])') #10166

Closed

snyk-bot mentioned this pull request Aug 20, 2019

[Snyk] Upgrade @babel/runtime from 7.0.0 to 7.5.5 Watemlifts/storybook#7

Closed

snyk-bot mentioned this pull request Sep 23, 2019

[Snyk] Upgrade @babel/runtime from 7.4.4 to 7.6.0 Matthelonianxl/drizzle#2

Open

This was referenced Oct 3, 2019

[Snyk] Upgrade @babel/runtime from 7.4.4 to 7.6.2 Matthelonianxl/drizzle#6

Open

[Snyk] Upgrade @babel/preset-env from 7.4.5 to 7.6.2 bitrise-io/blog-v2#15

Open

[Snyk] Upgrade @babel/core from 7.4.5 to 7.6.2 bitrise-io/blog-v2#16

Open

lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019

lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019

saschanaz deleted the spread-fix branch May 15, 2020 20:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Retry to fix object spread helper compatibility #9384

Retry to fix object spread helper compatibility #9384

saschanaz commented Jan 22, 2019 •

edited

nicolo-ribaudo commented Jan 22, 2019

saschanaz commented Jan 22, 2019

saschanaz commented Jan 22, 2019

babel-bot commented Jan 22, 2019 •

edited

saschanaz commented Jan 22, 2019

nicolo-ribaudo commented Jan 22, 2019

saschanaz commented Feb 7, 2019

saschanaz commented Feb 18, 2019 •

edited

saschanaz commented Feb 22, 2019

nicolo-ribaudo commented Feb 22, 2019

saschanaz commented Feb 22, 2019 via email

danez Mar 1, 2019

nicolo-ribaudo Mar 3, 2019

danez Mar 3, 2019 •

edited

nicolo-ribaudo Mar 3, 2019

saschanaz Mar 13, 2019

nicolo-ribaudo Mar 13, 2019

saschanaz Mar 13, 2019

nicolo-ribaudo Mar 13, 2019

danez left a comment

buildsize bot commented May 25, 2019

nicolo-ribaudo commented May 25, 2019

mathieutu commented Jun 1, 2019

cloudkite commented Jul 5, 2019

nicolo-ribaudo commented Jul 5, 2019

QingLeiLi commented Jul 5, 2019 •

edited

pwnreza commented Jul 5, 2019

kimroen commented Jul 5, 2019

QingLeiLi commented Jul 5, 2019

Udbhav12 commented Jul 5, 2019

QingLeiLi commented Jul 8, 2019 •

edited

pwnreza commented Jul 8, 2019

kimroen commented Jul 8, 2019

Retry to fix object spread helper compatibility #9384

Retry to fix object spread helper compatibility #9384

Conversation

saschanaz commented Jan 22, 2019 • edited

nicolo-ribaudo commented Jan 22, 2019

saschanaz commented Jan 22, 2019

saschanaz commented Jan 22, 2019

babel-bot commented Jan 22, 2019 • edited

saschanaz commented Jan 22, 2019

nicolo-ribaudo commented Jan 22, 2019

saschanaz commented Feb 7, 2019

saschanaz commented Feb 18, 2019 • edited

saschanaz commented Feb 22, 2019

nicolo-ribaudo commented Feb 22, 2019

saschanaz commented Feb 22, 2019 via email

danez Mar 1, 2019

Choose a reason for hiding this comment

nicolo-ribaudo Mar 3, 2019

Choose a reason for hiding this comment

danez Mar 3, 2019 • edited

Choose a reason for hiding this comment

nicolo-ribaudo Mar 3, 2019

Choose a reason for hiding this comment

saschanaz Mar 13, 2019

Choose a reason for hiding this comment

nicolo-ribaudo Mar 13, 2019

Choose a reason for hiding this comment

saschanaz Mar 13, 2019

Choose a reason for hiding this comment

nicolo-ribaudo Mar 13, 2019

Choose a reason for hiding this comment

danez left a comment

Choose a reason for hiding this comment

buildsize bot commented May 25, 2019

nicolo-ribaudo commented May 25, 2019

mathieutu commented Jun 1, 2019

cloudkite commented Jul 5, 2019

nicolo-ribaudo commented Jul 5, 2019

QingLeiLi commented Jul 5, 2019 • edited

pwnreza commented Jul 5, 2019

kimroen commented Jul 5, 2019

QingLeiLi commented Jul 5, 2019

Udbhav12 commented Jul 5, 2019

QingLeiLi commented Jul 8, 2019 • edited

pwnreza commented Jul 8, 2019

kimroen commented Jul 8, 2019

saschanaz commented Jan 22, 2019 •

edited

babel-bot commented Jan 22, 2019 •

edited

saschanaz commented Feb 18, 2019 •

edited

danez Mar 3, 2019 •

edited

QingLeiLi commented Jul 5, 2019 •

edited

QingLeiLi commented Jul 8, 2019 •

edited