New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tls: add SNI support #2930
tls: add SNI support #2930
Conversation
Build SUCCESS |
Build SUCCESS |
Build SUCCESS |
Build SUCCESS |
6ae88a5
to
64da65a
Compare
Build SUCCESS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A last note:
sni
belongs to TLSContext, but in OpenSSL, we couldn't find a setter for SSL_CTX
, just for SSL
, so the validation is done in tls_session_new()
, which runs after init()
, and in case of failure, it is repeated every time-reopen()
seconds.
I think this is not a big problem, SSL_set_tlsext_host_name()
fails in very rare cases, for example, when the host name is unreasonably long (or when memory can't be allocated).
https://tools.ietf.org/html/rfc6066#page-6 Signed-off-by: Attila Szakacs <attila.szakacs@balabit.com>
Signed-off-by: Attila Szakacs <attila.szakacs@balabit.com>
Build SUCCESS |
Inspired by a syslog-ng maillist request:
Example usage:
Wireshark:
Signed-off-by: Attila Szakacs attila.szakacs@balabit.com